ruffle icon indicating copy to clipboard operation
ruffle copied to clipboard

desktop: Do not resize the window while it is maximized

Open sleepycatcoding opened this issue 1 year ago • 5 comments

Fixes #11364.

sleepycatcoding avatar Apr 12 '24 19:04 sleepycatcoding

Testing the original issue now, I notice that on Windows, loading an SWF into a maximized window does result in a resize, but the window doesn't realize that it is now unmaximized, so it takes two clicks to maximize the window again:

https://github.com/ruffle-rs/ruffle/assets/71368227/d0069dae-a3ae-4c7e-931c-fb6183a7a025

I guess we should look into fixing this behavior, maybe in a followup. (I can open a new issue if this doesn't seem easy to solve)

n0samu avatar Apr 12 '24 20:04 n0samu

Maybe we shouldn't try to resize the window at all when it is maximized?

sleepycatcoding avatar Apr 12 '24 20:04 sleepycatcoding

Sounds good to me!

n0samu avatar Apr 12 '24 20:04 n0samu

@n0samu could you test the changes on Windows to see if it fixes the window desync. (I don't have a Windows environment to test myself)

sleepycatcoding avatar Apr 12 '24 21:04 sleepycatcoding

Just tested and it's working well now, thanks! 👍

n0samu avatar Apr 12 '24 21:04 n0samu

is this ready?

Croworbit avatar Jul 23 '24 20:07 Croworbit