ruffle icon indicating copy to clipboard operation
ruffle copied to clipboard

core: Remove LoaderHandle when load is done

Open Aaron1011 opened this issue 1 year ago • 2 comments

In almost all cases, we were letting completed LoaderHandles accumulate, leaking memory and wasting time in preload_tick

Aaron1011 avatar Feb 04 '24 04:02 Aaron1011

Sorry, maybe reviewed too quickly.

I notice that some places have the potential to return early with ? before getting to this line. Is that going to be an issue?

Is there another way we can do this?

Dinnerbone avatar Feb 07 '24 19:02 Dinnerbone

I'm wondering if we can abuse RAII/Drop to make loaders close themselves regardless of whether or not they exit normally or not.

kmeisthax avatar May 25 '24 06:05 kmeisthax