ruffle icon indicating copy to clipboard operation
ruffle copied to clipboard

avm2: Implement flash.media.ID3Info

Open lvyitian opened this issue 1 year ago • 7 comments

lvyitian avatar Jan 23 '24 17:01 lvyitian

Thank you! Any chance of a test? :D

Dinnerbone avatar Jan 23 '24 17:01 Dinnerbone

I've never tried of making a test, and I don't know how to do it, I'd appreciate if you could write one for me.

lvyitian avatar Jan 23 '24 17:01 lvyitian

Great work implementing this, thanks!

evilpie avatar Jan 26 '24 20:01 evilpie

The documentation claims that ID3Info also dynamically supports a lot of other tags, which this doesn't cover. Not something that needs to be implemented before landing to be clear.

The following table describes ID3 tags that are supported but do not have predefined properties in the Sound class.

https://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/media/Sound.html#id3

evilpie avatar Jan 26 '24 20:01 evilpie

The documentation claims that ID3Info also dynamically supports a lot of other tags, which this doesn't cover. Not something that needs to be implemented before landing to be clear.

The following table describes ID3 tags that are supported but do not have predefined properties in the Sound class.

https://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/media/Sound.html#id3

Yes, I've read this, but there isn't a direct way to get those fields, so I haven't implemented them.

lvyitian avatar Jan 26 '24 21:01 lvyitian

Can you add a test?

Added.

lvyitian avatar Feb 09 '24 08:02 lvyitian

@Dinnerbone So, what should I do?

lvyitian avatar Feb 17 '24 08:02 lvyitian

there's no way of accessing filesystem directly

Ruffle's test backend supports doing a new URLRequest("test_audio.mp3").

Lord-McSweeney avatar Feb 29 '24 00:02 Lord-McSweeney

@Dinnerbone Solved.

lvyitian avatar Feb 29 '24 15:02 lvyitian