SkippingStones icon indicating copy to clipboard operation
SkippingStones copied to clipboard

Remove / Reason behind "placeholder"

Open smurfy opened this issue 10 years ago • 3 comments

Why do you replace empty strings in the notification part with "placeholder" ? The notifications test GUI works with empty-strings to -> pebble just fine.

smurfy avatar Jun 24 '14 09:06 smurfy

IIrc, the rationale for this was to indicate that this field still needs to be filled or handled properly. Furthermore, another intention was to provide some means for anticipating where and how things will be displayed on the watch.

It might also have been that in some very early versions the handling of empty strings was not properly but I don't recall this exactly anymore. Apparently, as you found out, empty strings work.

ruedigergad avatar Jun 24 '14 17:06 ruedigergad

I plan to work a bit on SkippingStones, i have two main things i want to change.

  • Clean up notifications (covers this issue)
  • Clean up main ui (Separate developer stuff from consumer)

I would create a pull request for each part.

smurfy avatar Jun 24 '14 17:06 smurfy

Cool, this sounds great.

With respect to the "placeholder", maybe add a boolean variable to set whether "placeholder" texts are shown or not. Reason for this is that it still might be useful at times when developing. This variable could default to false and thus no placeholder text would be shown unless explicitly set otherwise.

With respect to UI improvements, sure, that sounds good as well.

ruedigergad avatar Jun 24 '14 18:06 ruedigergad