VobSub2SRT icon indicating copy to clipboard operation
VobSub2SRT copied to clipboard

Fix compile with gcc7 and tesseract 4

Open bit opened this issue 6 years ago • 8 comments

bit avatar Sep 09 '18 07:09 bit

should be in CXX, not in C

sl1pkn07 avatar Feb 10 '19 13:02 sl1pkn07

You want to remove set(CMAKE_C_FLAGS "-std=gnu99") and add -std to CXX flags?

bit avatar Feb 12 '19 08:02 bit

set(CMAKE_CXX_FLAGS "-ansi -pedantic -Wall -Wextra -Wno-long-long -std=gnu++11")

instead of

set(CMAKE_C_FLAGS "-std=gnu++11")

sl1pkn07 avatar Feb 12 '19 14:02 sl1pkn07

any chance to merge this?

bit avatar Mar 15 '19 11:03 bit

The alternative set(CMAKE_CXX_STANDARD 11) — proposed in issue https://github.com/ruediger/VobSub2SRT/issues/73 — works too and is maybe more elegant.

Chris00 avatar Feb 12 '20 21:02 Chris00

I use gcc (Debian 9.2.1-25) 9.2.1 20200123 and this patch (or the alternative) is still required.

Chris00 avatar Feb 12 '20 22:02 Chris00

I can confirm this fixed for me build on Linux

glensc avatar Mar 29 '20 11:03 glensc

This PR needed for docker build too: https://github.com/ruediger/VobSub2SRT/pull/77

glensc avatar Apr 07 '20 05:04 glensc