homebridge-http I can maintain

I can maintain

Open gbougakov opened this issue 7 years ago • 6 comments

NPM username: georgenet I understand everything inside the code.

Feb 28 '17 16:02 gbougakov

I found a bug and I know how to fix it. (In the npm version)

Mar 03 '17 13:03 gbougakov

Is the bug in the github version too? Not sure If I can add you to the npm version.

If you have anything feel free to do a pull request.

Mar 04 '17 01:03 NovaGL

@NovaGL Actually code in npm and github is different, but none of them are stable and homebridge crashes when it reaches here.

Line 46 says done(error); That throws an uncaught "critical" network error, as a result - homebridge crashes.

Replace done(error); with this

Mar 06 '17 15:03 gbougakov

Actually IDK is it only on my server so unstable, so I had to rewrite all the plugin to make it stable?

Mar 06 '17 15:03 gbougakov

@NovaGL And yep, the npm version instead of done(error); says callback(error);

Mar 06 '17 15:03 gbougakov

I don't think I can add you as I am not the owner, but I can merge your requests.

Mar 07 '17 08:03 NovaGL