rudder-transformer icon indicating copy to clipboard operation
rudder-transformer copied to clipboard

fix: move af_currency outside properties in eventValue

Open yashasvibajpai opened this issue 1 year ago • 3 comments

What are the changes introduced in this PR?

This change affects the Appsflyer destination. We are moving af_currency outside the properties object inside eventValue similar to how af_revenue is handled.

What is the related Linear task?

Resolves INT-2066

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • [ ] My code follows the style guidelines of this project

  • [ ] No breaking changes are being introduced.

  • [ ] All related docs linked with the PR?

  • [ ] All changes manually tested?

  • [ ] Any documentation changes needed with this change?

  • [ ] Is the PR limited to 10 file changes?

  • [ ] Is the PR limited to one linear task?

  • [ ] Are relevant unit and component test-cases added?

Reviewer checklist

  • [ ] Is the type of change in the PR title appropriate as per the changes?

  • [ ] Verified that there are no credentials or confidential data exposed with the changes.

yashasvibajpai avatar Apr 26 '24 08:04 yashasvibajpai

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3316/test-report.html

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.90%. Comparing base (ea655bf) to head (06fffe9). Report is 172 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3316      +/-   ##
===========================================
+ Coverage    87.84%   87.90%   +0.05%     
===========================================
  Files          558      561       +3     
  Lines        30074    30169      +95     
  Branches      7198     7224      +26     
===========================================
+ Hits         26419    26520     +101     
+ Misses        3352     3346       -6     
  Partials       303      303              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 26 '24 09:04 codecov[bot]