bug: ack cumulative on pulsar

[fracasula]

Description

Reproducing AckCumulative bug on Pulsar.

To run the test, pull the project, get into the ./cmd/ack folder and run:

go test -v -count 1 -race .

Example output

    ack_test.go:115: UnAcked messages: 43147
    ack_test.go:129: BufferWithTimeout: 729 messages, 1.000012224s buffer time
    ack_test.go:136: We received 729 messages. Acking last ID : "9:43188:0"
    ack_test.go:129: BufferWithTimeout: 730 messages, 1.000129154s buffer time
    ack_test.go:136: We received 730 messages. Acking last ID : "9:43918:0"
    ack_test.go:129: BufferWithTimeout: 722 messages, 1.00025047s buffer time
    ack_test.go:136: We received 722 messages. Acking last ID : "9:44640:0"
    ack_test.go:129: BufferWithTimeout: 731 messages, 1.000929136s buffer time
    ack_test.go:136: We received 731 messages. Acking last ID : "9:45371:0"
    ack_test.go:129: BufferWithTimeout: 734 messages, 1.000103214s buffer time
    ack_test.go:136: We received 734 messages. Acking last ID : "9:46105:0"
    ack_test.go:129: BufferWithTimeout: 729 messages, 1.000098143s buffer time
    ack_test.go:136: We received 729 messages. Acking last ID : "9:46834:0"
    ack_test.go:129: BufferWithTimeout: 741 messages, 1.000961664s buffer time
    ack_test.go:136: We received 741 messages. Acking last ID : "9:47575:0"
    ack_test.go:129: BufferWithTimeout: 718 messages, 1.00008832s buffer time
    ack_test.go:136: We received 718 messages. Acking last ID : "9:48293:0"
    ack_test.go:129: BufferWithTimeout: 729 messages, 1.000120943s buffer time
    ack_test.go:136: We received 729 messages. Acking last ID : "9:49022:0"
    ack_test.go:129: BufferWithTimeout: 734 messages, 1.000074187s buffer time
    ack_test.go:136: We received 734 messages. Acking last ID : "9:49756:0"
    ack_test.go:115: UnAcked messages: 50000
    ack_test.go:129: BufferWithTimeout: 243 messages, 1.000232772s buffer time
    ack_test.go:136: We received 243 messages. Acking last ID : "9:49999:0"
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.000011879s buffer time
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.000341405s buffer time
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.000678685s buffer time
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.000678189s buffer time
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.000395633s buffer time
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.000030104s buffer time
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.000178602s buffer time
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.0007541s buffer time
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.000225721s buffer time
    ack_test.go:115: UnAcked messages: 50000
    ack_test.go:129: BufferWithTimeout: 0 messages, 1.000822534s buffer time

As you can see, after reaching 50k unacked messages, the consumer stops receiving messages despite the fact that we've been acking the messages after receving each batch with AckIDCumulative.

Linear Ticket

< Linear Link >

Security

• [x] The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[coderabbitai[bot]]

[!IMPORTANT]

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.