rudder-server icon indicating copy to clipboard operation
rudder-server copied to clipboard

feat(warehouse): added error handling for syncs errors

Open achettyiitr opened this issue 2 years ago • 1 comments

Description

Proper error handling for warehouse modules to handle these cases:

  • Customer doesn’t need to be exposed about the internal of the Rudderstack error where and what it is happening in the Rudderstack codebase.
  • We also wanted to capture these error so that we can categorize them as customer specific ot not. Since not 100% of the errors can be captured with the confgiration tests we are running after getting some error during the syncs. [CFD](https://www.notion.so/Snowflake-Insufficient-Privilege-1a28817ff72a46aabe7548dc3c22cc89).
  • Currently there is no difference between what should be shown to the customers and what we should log it.
  • How should we expose the defaults error which is happening during the processing of syncs on the Rudderstacks end.
  • Error exposed to the customer around the syncs dashboard. Since these looks like cryptic errors and customer doesn’t know what going behind the scenes. We should just show plain vanilla errors for the actions we are getting.

Notion Ticket

https://www.notion.so/rudderstacks/Error-handling-f8245e749399460eb271b7cba0e01589

Security

  • [x] The code changed/added as part of this pull request won't create any security issues with how the software is being used.

achettyiitr avatar Sep 21 '22 12:09 achettyiitr

Codecov Report

Base: 38.67% // Head: 38.61% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (4a7c5ad) compared to base (082b9f5). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2464      +/-   ##
==========================================
- Coverage   38.67%   38.61%   -0.06%     
==========================================
  Files         166      167       +1     
  Lines       36683    36719      +36     
==========================================
- Hits        14186    14179       -7     
- Misses      21580    21624      +44     
+ Partials      917      916       -1     
Impacted Files Coverage Δ
warehouse/errors.go 0.00% <0.00%> (ø)
utils/httputil/server.go 80.76% <0.00%> (-11.54%) :arrow_down:
processor/processor.go 71.26% <0.00%> (-0.83%) :arrow_down:
warehouse/warehouse.go 3.13% <0.00%> (-0.03%) :arrow_down:
warehouse/api.go 0.00% <0.00%> (ø)
config/backend-config/backend-config.go 69.88% <0.00%> (+0.56%) :arrow_up:
enterprise/reporting/reporting.go 9.82% <0.00%> (+1.44%) :arrow_up:
config/backend-config/namespace_config.go 78.62% <0.00%> (+2.29%) :arrow_up:
enterprise/reporting/setup.go 52.38% <0.00%> (+14.28%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 21 '22 12:09 codecov[bot]

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

github-actions[bot] avatar Oct 12 '22 02:10 github-actions[bot]