rudder-server icon indicating copy to clipboard operation
rudder-server copied to clipboard

chore: add reason tag in failed requests and failed events stats

Open satishrudderstack opened this issue 2 years ago • 2 comments

Currently, we have stats for failed requests and failed events. With this change we will also be capturing the reason for the failure. Example reasons are invalidJson, invalidWriteKey

satishrudderstack avatar Sep 13 '22 03:09 satishrudderstack

Codecov Report

Base: 45.30% // Head: 43.96% // Decreases project coverage by -1.34% :warning:

Coverage data is based on head (a91654e) compared to base (60bc1be). Patch coverage: 25.94% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2430      +/-   ##
==========================================
- Coverage   45.30%   43.96%   -1.35%     
==========================================
  Files         177      187      +10     
  Lines       36542    39108    +2566     
==========================================
+ Hits        16555    17193     +638     
- Misses      18911    20828    +1917     
- Partials     1076     1087      +11     
Impacted Files Coverage Δ
processor/transformer/transformer.go 65.76% <0.00%> (-0.46%) :arrow_down:
router/batchrouter/batchrouter.go 34.13% <0.00%> (-0.02%) :arrow_down:
services/filemanager/filemanager.go 53.09% <0.00%> (-1.45%) :arrow_down:
warehouse/admin.go 3.03% <0.00%> (ø)
warehouse/bigquery/bigquery.go 0.00% <0.00%> (ø)
warehouse/clickhouse/clickhouse.go 0.00% <0.00%> (ø)
warehouse/deltalake/deltalake.go 0.00% <0.00%> (ø)
warehouse/deltalake/query_builder.go 0.00% <0.00%> (ø)
warehouse/errors.go 0.00% <0.00%> (ø)
warehouse/identities.go 1.05% <0.00%> (-0.47%) :arrow_down:
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 13 '22 03:09 codecov[bot]

@lvrach Added a new commit to this PR. https://github.com/rudderlabs/rudder-server/pull/2430/commits/53779e3cbe1d662bfaa516f88b54487bfcce8028. Please take a look

satishrudderstack avatar Sep 23 '22 05:09 satishrudderstack