rudder-sdk-js
rudder-sdk-js copied to clipboard
fix: remove the rollup plugin to allow optional chaining syntax
Description of the change
Remove the unwanted rollup-plugin-node-globals
plugin that prevented the usage of the optional chaining operator ?
in the code.
Also, enabled compact
mode in Babel config to suppress the below warning:
[BABEL] Note: The code generator has deoptimised the styling of <xyz.js> as it exceeds the max of 500KB.
Type of change
- [x] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Related issues
N/A
Checklists
Development
- [ ] Lint rules pass locally
- [ ] The code changed/added as part of this pull request has been covered with tests
- [ ] All tests related to the changed code pass in development
Code review
- [ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
- [ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
- [ ] Changes have been reviewed by at least one other engineer
- [ ] Issue from task tracker has a link to this pull request
size-limit report π¦
Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
---|---|---|---|---|
Core - CDN | 36.04 KB (0%) | 721 ms (0%) | 1.9 s (+37.44% πΊ) | 2.6 s |
Core - CDN (modern only) | 33.82 KB (-0.01% π½) | 677 ms (-0.01% π½) | 1.1 s (-14.66% π½) | 1.8 s |
All Integrations - CDN | 656.78 KB (0%) | 13.2 s (0%) | 7.7 s (+3.89% πΊ) | 20.8 s |
All Integrations - CDN (modern only) | 518.62 KB (-0.02% π½) | 10.4 s (-0.02% π½) | 6.4 s (+18% πΊ) | 16.7 s |
Core - NPM | 36.02 KB (0%) | 721 ms (0%) | 2 s (+81.77% πΊ) | 2.7 s |
Service Worker - NPM | 25.06 KB (-0.1% π½) | 502 ms (-0.1% π½) | 1.1 s (-15.49% π½) | 1.6 s |
is this still in draft or we can progress?
is this still in draft or we can progress?
It's still a draft for now as I observed some implications on the NPM package bundle. I'll try to sort them out this week.
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 10 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 10 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 10 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.