rudder-sdk-js icon indicating copy to clipboard operation
rudder-sdk-js copied to clipboard

fix(core): execute buffered requests during load API

Open MoumitaM opened this issue 2 years ago โ€ข 1 comments

Description of the change

  • Updated request buffering part during SDK initialization.
  • Added a call to execute buffered requests at the end of load API.

Type of change

  • [x] Bug fix (non-breaking change that fixes an issue)
  • [ ] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #665

Checklists

Development

  • [ ] Lint rules pass locally
  • [ ] The code changed/added as part of this pull request has been covered with tests
  • [ ] All tests related to the changed code pass in development

Code review

  • [ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • [ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • [ ] Changes have been reviewed by at least one other engineer
  • [ ] Issue from task tracker has a link to this pull request

This change isโ€‚Reviewable

MoumitaM avatar Oct 12 '22 11:10 MoumitaM

size-limit report ๐Ÿ“ฆ

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 39.18 KB (+0.11% ๐Ÿ”บ) 784 ms (+0.11% ๐Ÿ”บ) 662 ms (-32.32% ๐Ÿ”ฝ) 1.5 s
All Integrations - CDN 581.85 KB (0%) 11.7 s (0%) 3.4 s (+16.31% ๐Ÿ”บ) 15 s
Core - NPM 39.37 KB (+0.12% ๐Ÿ”บ) 788 ms (+0.12% ๐Ÿ”บ) 553 ms (+8.48% ๐Ÿ”บ) 1.4 s

github-actions[bot] avatar Oct 12 '22 11:10 github-actions[bot]