rudder-sdk-js icon indicating copy to clipboard operation
rudder-sdk-js copied to clipboard

Event name in page call in Customer.io is too long

Open mderazon opened this issue 3 years ago • 3 comments

Getting these errors from Customer.io:

event name cannot be longer than 100 bytes

With this (example) payload

{
  "data": {
    "initial_referrer": "$direct",
    "initial_referring_domain": "",
    "path": "/help/creating-a-google-calendar-account-that-uses-your-business-email-address",
    "referrer": "$direct",
    "referring_domain": "",
    "search": "",
    "tab_url": "https://help.oncehub.com/help/creating-a-google-calendar-account-that-uses-your-business-email-address",
    "title": "Creating a Google Calendar account that uses your business email address | OnceHub",
    "url": "https://help.oncehub.com/help/creating-a-google-calendar-account-that-uses-your-business-email-address"
  },
  "name": "https://help.oncehub.com/help/creating-a-google-calendar-account-that-uses-your-business-email-address",
  "timestamp": 1621642003,
  "type": "page"
}

Customer.io does not natively support a page call, so it's being sent as a regular event with the name as the page url. Page url can easily exceed 100 bytes.

Maybe it's better to use a constant name for the event and send the page url as a prop

Happy to provide a PR if you can suggest the desired solution

mderazon avatar May 31 '21 06:05 mderazon

@mderazon Thanks for raising the issue. We'd be happy to review the updates if you can raise the PR.

saikumarrs avatar Dec 28 '21 10:12 saikumarrs

@mderazon Gentle reminder to raise a PR for this. Please let us know if you want us to do that.

saikumarrs avatar Feb 14 '22 16:02 saikumarrs

Hey @saikumarrs have been out of touch with this issue for some time, please let me check it again and get back to you

Do you think it's better to fix this here / in the transformer ?

mderazon avatar Feb 15 '22 16:02 mderazon

@mderazon This issue has been addressed in the cloud mode integration. A gentle reminder to raise a PR to fix this issue here.

saikumarrs avatar Sep 27 '22 06:09 saikumarrs

Hi, @mderazon, we tried to reproduce this issue via web-device mode and sent page events with the exact URL provided in the example. We did not face any problems with this. Can you check once again?

We sent the following call to test:

  rudderanalytics.page("category", "https://help.oncehub.com/help/creating-a-google-calendar-account-that-uses-your-business-email-address", {
  path: "test-path",
  url: "https://help.oncehub.com/help/creating-a-google-calendar-account-that-uses-your-business-email-address",
  title: "title",
  search: "search",
  referrer: "https://help.oncehub.com/help/creating-a-google-calendar-account-that-uses-your-business-email-address",
});

And received output in customerIO dashboard.

Screenshot 2022-09-29 at 12 15 28 PM

shrouti1507 avatar Sep 29 '22 06:09 shrouti1507

closing this as no correspondence received

shrouti1507 avatar Oct 11 '22 05:10 shrouti1507