Invoice: Optional payment fields override Quickbooks default handling

[vanboom]

We have noticed that invoices exported to Quickbooks Online do not follow the default settings to allow online credit card payments. When building invoices, we are not setting these fields, but they appear to be sent over in the payload...

<Invoice>
....
<AllowOnlinePayment>false</AllowOnlinePayment>
<AllowOnlineCreditCardPayment>false</AllowOnlineCreditCardPayment>
<AllowOnlineACHPayment>false</AllowOnlineACHPayment>
</Invoice>

It appears that we are commanding Quickbooks optional fields such as AllowOnlineCreditCardPayment which we are never setting on our invoice model. My suggestion would be to not send these optional fields if they are 'nil' to allow Quickbooks default handling to take effect.

[rasulsh]

I’m dealing with the same problem as you

[ramzlab000]

I think there's already a pull request https://github.com/SamKirkland/FTP-Deploy-Action/pull/415 - this should fix the issue!

[rasulsh]

I think there's already a pull request #415 - this should fix the issue!

As of now, since it hasn't been merged with the master branch and the new version hasn't been released, we'll have to wait

[maverage]

I updated the dependencies and built it with node 20 without issues, seems to be working for me https://github.com/maverage/FTP-Deploy-Action/releases/tag/v4.3.5

I hope it will be fixed here soon, I created a PR #435

[ramzlab000]

I updated the dependencies and built it with node 20 without issues, seems to be working for me https://github.com/maverage/FTP-Deploy-Action/releases/tag/v4.3.5

I hope it will be fixed here soon, I created a PR #435

I'm using yours for now. Thanks!

[SamKirkland]

Available in the latest v4.3.5 release