quickbooks-ruby
quickbooks-ruby copied to clipboard
ruckus
Add support for Minor Version 1 which adds TaxInclusiveAmt attribute …
…Line.SalesItemLineDetail, Line.ItemBasedExpenseLineDetail, and Line.AccountBasedExpenseLineDetail line types.
This adds support for additional attributes used outside of the US that allow prices to be displayed as tax inclusive amounts.
Missed some code and updates to 0.6.2.
This update has now been reverted as I had assumed that the changes in the 0.6.2 gem were updates, whereas they were really the old level of code.
Thanks for the PR. The specs are failing. We'll need a green build for a merge. Thanks again!
@SpiffyStores
Do you plan on fixing those changes? If not, I can take those changes and create a new PR out of them?
@SpiffyStores
Do you plan on fixing those changes? If not, I can take those changes and create a new PR out of them?
There's nothing wrong with the changes. The problem in the Travis CI build seems to have nothing to do with the updates, and is reporting that there are no environment variables set. This is not something I can fix.
Any advice?
@SpiffyStores Do you plan on fixing those changes? If not, I can take those changes and create a new PR out of them?
There's nothing wrong with the changes. The problem in the Travis CI build seems to have nothing to do with the updates, and is reporting that there are no environment variables set. This is not something I can fix.
Any advice?
Ok, I can see that the specs need updating to support the additional minorversion parameter, but at the moment, I don't have much of an understanding on how the specs have been written and how they interact with QB.
I know that the actual code updates are good, but I may need some help and time to get the spec code updated to match the code update.
@ruckus any idea on when can be this SalesItemLineDetail will have TaxInclusiveAmt attribute?
