rucio icon indicating copy to clipboard operation
rucio copied to clipboard

RSE Decommissioner: add cms profile

Open eachristgr opened this issue 8 months ago • 6 comments

Description

This PR introduces a CMS-specific profile for the RSE decommissioner. The profile partially leverages functionality from the generic profiles, while also extending them and adding new features to address CMS-specific use cases.

Related Issues:

https://github.com/dmwm/CMSRucio/issues/585

eachristgr avatar Apr 07 '25 10:04 eachristgr

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 6.86%. Comparing base (4618b6b) to head (8c444a4).

Files with missing lines Patch % Lines
...ib/rucio/daemons/rsedecommissioner/profiles/cms.py 0.00% 60 Missing :warning:
...cio/daemons/rsedecommissioner/profiles/__init__.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #7636      +/-   ##
=========================================
- Coverage    6.87%   6.86%   -0.01%     
=========================================
  Files         266     267       +1     
  Lines       44597   44658      +61     
=========================================
  Hits         3065    3065              
- Misses      41532   41593      +61     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 07 '25 10:04 codecov[bot]

I do not think this PR in its entirety should be in rucio core. Adding additional profiles through a plugin or a patch is probably more appropriate.

voetberg avatar Apr 07 '25 16:04 voetberg

I do not think this PR in its entirety should be in rucio core. Adding additional profiles through a plugin or a patch is probably more appropriate.

Not sure if we already have plugin support for decommissioner profiles. Slightly relevant - https://github.com/rucio/rucio/issues/7340

rdimaio avatar Apr 07 '25 16:04 rdimaio

I do not think this PR in its entirety should be in rucio core. Adding additional profiles through a plugin or a patch is probably more appropriate.

Not sure if we already have plugin support for decommissioner profiles. Slightly relevant - #7340

Yep, sorry my comment was misleading. I think if we want to include this type of functionality @eachristgr , we should focus on making decommisioner profiles plugin ready first - I'd be open to talking with you about it

voetberg avatar Apr 07 '25 17:04 voetberg

I do not think this PR in its entirety should be in rucio core. Adding additional profiles through a plugin or a patch is probably more appropriate.

Not sure if we already have plugin support for decommissioner profiles. Slightly relevant - #7340

Yep, sorry my comment was misleading. I think if we want to include this type of functionality @eachristgr , we should focus on making decommisioner profiles plugin ready first - I'd be open to talking with you about it

Thanks for the feedback and guidance. I agree that including CMS-specific functionality directly in Rucio core isn’t ideal — that’s also one of the reasons I initially opened the PR as a draft. I’d be happy to learn more about the appropriate way to handle this and contribute to any additional development needed. If it’s too much to discuss here, I’m also open to having a chat or call offline. Let me know what works best!

eachristgr avatar Apr 08 '25 08:04 eachristgr

Could you link an issue to this one please?

Geogouz avatar Dec 09 '25 19:12 Geogouz