ruby-advisory-db icon indicating copy to clipboard operation
ruby-advisory-db copied to clipboard

Update titles/descriptions for NVD advisories.

Open FionaDL opened this issue 4 years ago • 5 comments

As suggested by @postmodern in comment https://github.com/rubysec/ruby-advisory-db/issues/251#issuecomment-606172546 it would be nice to update the titles/descriptions for each advisory on using NVD as a url. However, one thing I noticed is that there are no titles on NVD site. The descriptions could be updated. What do you think is the best approach @postmodern ?

FionaDL avatar Apr 02 '20 18:04 FionaDL

Hmm let's wait on titles since that will require manually summarizing the description. Descriptions can be scraped from NVD (//p[@data-testid="vuln-description"]).

postmodern avatar Apr 06 '20 03:04 postmodern

hi @postmodern and @FionaDL I was trying to take a quick peek at this but noticed that most CVE yaml files already have a title in them. For instance https://github.com/rubysec/ruby-advisory-db/blob/beb6c9260248b82292004a619da349b1aeec3d9f/gems/kafo/CVE-2014-0135.yml#L6

What are we missing then? Sorry if this is something that's obvious as I'm not able to find it.

simar7 avatar Aug 21 '20 21:08 simar7

Was the idea to update these titles as they are possibly coming from OSVDB and might have copyright issues? Sorry just trying to fill in myself on the context.

simar7 avatar Aug 21 '20 21:08 simar7

Hi @simar7 ! Yes, I think the idea was that since the titles are leftover from the old links to the OSVDB website that we should update the titles and descriptions to match the links that they are now pointing at. Unfortunately the https://nvd.nist.gov site doesn't seem to use titles. They do have updated descriptions though.

FionaDL avatar Aug 24 '20 13:08 FionaDL

Hi @simar7 ! Yes, I think the idea was that since the titles are leftover from the old links to the OSVDB website that we should update the titles and descriptions to match the links that they are now pointing at. Unfortunately the https://nvd.nist.gov site doesn't seem to use titles. They do have updated descriptions though.

Thanks. I've created a PR here to address it https://github.com/rubysec/ruby-advisory-db/pull/456

simar7 avatar Aug 25 '20 22:08 simar7

Closing since #456 was merged.

postmodern avatar May 23 '23 20:05 postmodern