speakerinnen_liste icon indicating copy to clipboard operation
speakerinnen_liste copied to clipboard

Check and Update Active Storage behaviour with profile images

Open zaziemo opened this issue 4 years ago • 3 comments

With the update from Rails 5.2 to 6.0 we observed a different cropping behaviour of the profile images. Apparently there are a few changes to how Active Storage processes variants of the images: https://bloggie.io/@kinopyo/upgrade-guide-active-storage-in-rails-6

We should adapt this asap.

104614771-d8eec600-5688-11eb-936a-0e8023b4b6d4

zaziemo avatar Jan 14 '21 20:01 zaziemo

There is also a DEPRECATION WARNING: Active Storage's ImageProcessing transformer doesn't support :combine_options, as it always generates a single ImageMagick command. Passing :combine_options will not be supported in Rails 6.1.

sabrina-ulbrich avatar Dec 06 '21 23:12 sabrina-ulbrich

combine_options are removed in PR #1222

sabrina-ulbrich avatar Mar 26 '22 14:03 sabrina-ulbrich

@sabrina-ulbrich do we still need this?

zaziemo avatar Mar 28 '24 15:03 zaziemo

@zaziemo I don't think so. combine_options are already removed and the vips processor is mentioned in issue #1336. So I closed this issue.

sabrina-ulbrich avatar Mar 28 '24 21:03 sabrina-ulbrich