soap4r
soap4r copied to clipboard
Fix Regexp.new ArgumentError on ruby 3.3
Ruby 3.2 introduced a deprecation of the third positional parameter for encoding: https://github.com/ruby/ruby/commit/7e8fa06022a9e412e3f8e6c8b6f0ba1909f648d5
The argument was then removed in Ruby 3.3: https://github.com/ruby/ruby/commit/04cfb26bd394b8e92f24f18799f5e9fc96b2ea69
ArgumentError: wrong number of arguments (given 3, expected 1..2) (ArgumentError)
USASCIIRegexp = Regexp.new("\\A#{us_ascii}*\\z", nil, 'n')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@rubyjedi is there anything I can to to help with a merge?
@rubyjedi @kbrock is there any chance to merge this PR?
Ping @rubyjedi
PR accepted.
As I'm tooled up for other (non-Ruby) projects on my primary setup, I'll probably need a few days to retrofit a working environment to properly release an updated gem that includes this fix.
Thanks!
Thanks @rubyjedi !
@rubyjedi Gentle nudge. Would it be possible to get a release with this?
If not, myself or @agrare would be willing to help out.
@Fryguy my sincere apologies on allowing this to fall off my radar.
I have bumped the versions, tags, and gem releases to get them all back in sync.
Thank you! And no worries.
Awesome thanks a lot @rubyjedi
Thank you @rubyjedi