soap4r icon indicating copy to clipboard operation
soap4r copied to clipboard

Fix Regexp.new ArgumentError on ruby 3.3

Open agrare opened this issue 1 year ago • 1 comments

Ruby 3.2 introduced a deprecation of the third positional parameter for encoding: https://github.com/ruby/ruby/commit/7e8fa06022a9e412e3f8e6c8b6f0ba1909f648d5

The argument was then removed in Ruby 3.3: https://github.com/ruby/ruby/commit/04cfb26bd394b8e92f24f18799f5e9fc96b2ea69

ArgumentError: wrong number of arguments (given 3, expected 1..2) (ArgumentError)

  USASCIIRegexp = Regexp.new("\\A#{us_ascii}*\\z", nil, 'n')
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

agrare avatar Jan 25 '24 20:01 agrare

@rubyjedi is there anything I can to to help with a merge?

kbrock avatar Apr 05 '24 17:04 kbrock

@rubyjedi @kbrock is there any chance to merge this PR?

TomaszPanek avatar May 02 '24 07:05 TomaszPanek

Ping @rubyjedi

micwoj92 avatar May 28 '24 16:05 micwoj92

PR accepted.

rubyjedi avatar May 28 '24 16:05 rubyjedi

As I'm tooled up for other (non-Ruby) projects on my primary setup, I'll probably need a few days to retrofit a working environment to properly release an updated gem that includes this fix.

rubyjedi avatar May 28 '24 16:05 rubyjedi

Thanks!

micwoj92 avatar May 28 '24 17:05 micwoj92

Thanks @rubyjedi !

agrare avatar May 28 '24 17:05 agrare

@rubyjedi Gentle nudge. Would it be possible to get a release with this?

If not, myself or @agrare would be willing to help out.

Fryguy avatar Aug 01 '24 21:08 Fryguy

@Fryguy my sincere apologies on allowing this to fall off my radar.

I have bumped the versions, tags, and gem releases to get them all back in sync.

rubyjedi avatar Aug 04 '24 00:08 rubyjedi

Thank you! And no worries.

Fryguy avatar Aug 04 '24 00:08 Fryguy

Awesome thanks a lot @rubyjedi

agrare avatar Aug 04 '24 00:08 agrare

Thank you @rubyjedi

kbrock avatar Aug 04 '24 03:08 kbrock