go-oracle icon indicating copy to clipboard operation
go-oracle copied to clipboard

Handle GOPATH with ':' in it

Open rubyist opened this issue 11 years ago • 4 comments

The GOPATH environment variable can be a : separated list of paths. Properly handle when this is the case.

rubyist avatar Apr 07 '14 11:04 rubyist

Feel free to borrow code: https://github.com/joefitzgerald/go-plus/blob/1fb5093b0a2f7ddfd7db66b6f35d265eba4e1218/lib/dispatch.coffee#L168

joefitzgerald avatar Apr 08 '14 17:04 joefitzgerald

Cool. I saw your tweet the other day about pulling go-oracle into go-plus - I was thinking you might not be down with oracle being an external dependency that needs separate installation, but if that doesn't bother you then it might be worthwhile to merge efforts. I'm liking the idea of a single go package (outside of language-go, that is). It's also nice that we won't have to duplicate this kind of code.

I'll work up a PR in the next couple of days and see what you think.

rubyist avatar Apr 08 '14 17:04 rubyist

Yeah, I already have goimports and golint as external dependencies which require installation. For now, I just leave that functionality disabled by default, and default the configuration for the path preference to: $GOPATH/bin/<toolname> e.g. $GOPATH/bin/golint

I noticed you were doing lots of work on the display panel, and I recently took a dependency on atom-message-panel. I'm guessing that oracle might require new view(s), and they'll be similar to the view(s) I'll need to create for godoc support. But the good news is they are pluggable and we can benefit from the core functionality provided by the panel.

I'm all for merging if you're good with it. After all, go-plus is based on the work you started :) I'd also point out you are a contributor on the repo, so you can directly commit if you'd like.

joefitzgerald avatar Apr 08 '14 17:04 joefitzgerald

Bump!

binary132 avatar Nov 10 '15 15:11 binary132