rubygems
rubygems copied to clipboard
Fix check for missing spec in check_for_unmet_dependencies
What was the end-user or developer problem that led to this PR?
See #5422
What is your fix for the problem, implemented in this PR?
Add a check that catches the condition and handles it properly, see https://github.com/rubygems/rubygems/issues/5422#issuecomment-1106434053
Make sure the following tasks are checked
- [x] Describe the problem / feature
- [x] Write tests for features and bug fixes
- [x] Write code to solve the problem
- [x] Make sure you follow the current code style and write meaningful commit messages without tags
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.
We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.
If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.
For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide
- [x] code linting should be fine (rubocop does not complain)
- [x] fixed / enhanced existing tests to comply with changes
- [x] running the test-suite locally ~atm, but I already can see some failures~ (were non-related errors)
could this be merged?
Hi!
We never followed up on this because the original issue was no longer reproducible, although improving the error message in case the problem comes up again won't hurt.
What problem are you having?
Actually I'm pretty sure that with recent changes in our we materialize specs, this can no longer be triggered. So I'm going to close this with a big thanks to @Eusebius1920 for starting this work and helping figuring out root causes.
@sadfuzzy Please open a ticket with whatever issue you're having and we can figure it out from there!
Thanks both!!