Allow sorting gems alphabetically in the Profile show page
Hi! 👋 Looking at #3270, the idea of sorting gems in the rubygems.org page resonated with me. While this Pull Request does not implement all the sorting options mentioned in the issue (yet), it tries to lay the foundation for allowing to sort the gems displayed in the page.
If this approach is accepted, some follow-up questions are:
- Would this be implemented in other pages? (e.g. search results)
- How should we handle toggling between ascending or descending order?
Thanks for taking the time to review this! ☺️
Hello and thanks for opening this PR.
currently it looks aligned well on wide screen
but seems off on tiny screen
Is that intended?
@martinemde @segiddins any ideas how to make gem lists sortable for now? There are various ways to manipulate rendered collections like this one on games page.
There is other filter on search page.
@heyapricot what's your usecase for this?
@simi I was tackling issues from the list and on a personal note I've always been curious why sorting isn't an option
@simi Fixed the alignment issue on mobile
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.15%. Comparing base (
d5ec157) to head (b9e75bf). Report is 72 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #4471 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 391 391
Lines 8260 8261 +1
=======================================
+ Hits 8025 8026 +1
Misses 235 235
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.