gemstash icon indicating copy to clipboard operation
gemstash copied to clipboard

Published 20 hours ago • verified publisher icon rubygems

added fips flag

Open benklop opened this issue 4 years ago • 4 comments

Description:

Currently gemstash is not usable in environments with fips enforcement. https://github.com/rubygems/gemstash/pull/195 Tried to resolve this but has stalled for 3 years since it seems this needs to be enabled with a flag. @olleolleolle updated the changeset to add such a flag, but the changes never made it back here. In the meantime the diff stopped applying cleanly, I have fixed that and opened this PR.

I have made this use the config file option fips instead of a flag.

  • Fixes #194
  • Replaces https://github.com/rubygems/gemstash/pull/195

I will abide by the code of conduct.

benklop avatar Mar 18 '21 20:03 benklop

👋 Thanks for the interest in Gemstash.

There are tests covering the returned configuration, and they now fail. spec/gemstash/cli/info_spec.rb:74

olleolleolle avatar Mar 19 '21 07:03 olleolleolle

spec/gemstash/cli/info_spec.rb

looks like there were some additional differences in that config too. i've addressed those so that spec passes now.

benklop avatar Mar 19 '21 23:03 benklop

@benklop could you rebase this PR with master please, thank you! 🙇

bronzdoc avatar Jul 01 '21 00:07 bronzdoc