bundler-site
bundler-site copied to clipboard
rubygems
Unify duplicated use of rdiscount/kramdown and hpricot/nokogiri
Use nronn to unify use of rdiscount with kramdown, and to unify use of hpricot with nokogiri.
- rdiscount and kramdown both provide similar functionality: avoid to use rdicount
- hpricot and nokogiri both provide similar functionality: avoid to use hpricot
- Tested with Ruby 3.1 in CI (ronn has never continuously tested 😭).
Signed-off-by: Takuya Noguchi [email protected]>
I think it's a bit unfair to not mention ronn-ng at all here, since it's ronn-ng which took care of removing this dependency duplication. I think you should try to get ronn-ng mantainer to hand over maintenance to you, to save the whole community yet another migration to a different gem (I think OS packagers are already using ronn-ng).
If you don't succeed on taking over maintenance, then I think you should at least credit ronn-ng in this PR and in nronn's README. Also, I'm not sure why you didn't create nronn as a fork of ronn-ng, since that's what it is.
We're getting segfaults with ronn-ng now for some reason. Maybe nronn fixes them? What was the regression that you found, @tnir? The new fork looked pretty great. I think as long as we give proper attribution to ronn-ng, we could move forward with it!
@deivid-rodriguez Thanks. Were you looking at this failure only in GitHub Actions environment? I was not able to find failures even with ronn-ng on my local.
- Failed job: https://github.com/rubygems/bundler-site/actions/runs/3776821410/attempts/1
- and re-run succeeded job: https://github.com/rubygems/bundler-site/actions/runs/3776821410
@tnir Yes, I was looking at those failures indeed. Sometimes it does work, but they seem more frequent now. Since the crash happens deep inside hpricot's gem code, I figure moving away from that gem would do the trick.
Hpricot hasn't received updates for almost 10 years and declares itself as dead in its README, recommending to move on to nokogiri like nronn does.
I had a look at the site built from this PR and everything looks fine!
@tnir Would you be willing to take over ronn-ng maintenance? If current maintainer is ok with that, that'd be probably best for the community.
We can ask the current maintainer and see what he thinks. I don't think that needs to block this PR though, we could ask and merge this PR, and then switch back to ronn-ng in the future if the answer is positive.
Actually I'm doubly confused now that I double checked dependencies, since ronn-ng has also dropped the dependency on both nokogiri and rdiscount. What's the difference between nronn and ronn-ng?