playtime icon indicating copy to clipboard operation
playtime copied to clipboard

Paginate wishlist items

Open mcshakes opened this issue 7 years ago • 4 comments

Resolves #141

Description

Adds pagination.

Type of change

  • New feature (non-breaking change which adds functionality)

mcshakes avatar Oct 21 '17 20:10 mcshakes

While making the changes, I was tempted to add some data within the seeds to further test and edit the UI, but realized that is out of scope. So, I wanted to put in a request add more seeds for items, wishlist_items and some tests to fully flesh out functionality.

mcshakes avatar Oct 21 '17 20:10 mcshakes

@mcshakes That's a good idea; I made an issue (#157), and if we don't get a PR for it shortly, I'll make the change myself.

For now, I went onto your review app and added a bunch of items; that'll show you the current state of your PR. You can add items locally too by doing something similar to this in bin/rails console:

wishlist_item = WishlistItem.last
50.times do |n|
  new_item = wishlist_item.dup
  new_item.staff_message = "This is newly-added item ##{n+1}."
  new_item.save!
end

That'll add 50 new corgi plushes to your local app.

leesharma avatar Oct 22 '17 21:10 leesharma

@leesharma Sweet! Taking another look to correct some of the UI before pushing again

mcshakes avatar Oct 25 '17 22:10 mcshakes

@leesharma Ready to be merged, but looking at the conflicts; are those changes ones you wanted to keep?

mcshakes avatar Oct 26 '17 22:10 mcshakes