mutual-aid icon indicating copy to clipboard operation
mutual-aid copied to clipboard

More filtering cleanup

Open h-m-m opened this issue 4 years ago • 1 comments

Why

I wanted to try adding a filter now that we've refactored how filters work in #546

I also wanted to try @exbinary's suggestion about a refactor to how parameters are passed around. I feel like this refactor is not yet complete — for example we might want to look into some of the duplication that now exists — but I felt this is a good point to stop and ask for feedback before going further

What

Screen Shot 2021-04-17 at 11 36 27 AM

How

Testing

Next Steps

Outstanding Questions, Concerns and Other Notes

Accessibility

Security

Meta

Pre-Merge Checklist

  • [ ] Security & accessibility have been considered
  • [ ] Tests have been added, or an explanation has been given why the features cannot be tested
  • [ ] Documentation and comments have been added to the codebase where required
  • [ ] Entry added to CHANGELOG.md if appropriate
  • [ ] Outstanding questions and concerns have been resolved
  • [ ] Any next steps have been turned into Issues or Discussions as appropriate

h-m-m avatar Apr 17 '21 15:04 h-m-m

Looking great! Also curious your thoughts on my spike extracting serialization out of the filter, linked in this comment.

solebared avatar Apr 22 '21 17:04 solebared