rubyforgood
3805 partial Don't set partner_id when inviting existing users as partners.
Partial #3805
Description
Remove setting of user.partner_id in the case where we are inviting an existing user as a partner.
This is cleanup from the implementation of roles.
However -- there is the question of why it wasn't done in the first place, so we should be thorough in functional testing..
Once this goes in, we can do the final part of #3805, which will be some cleanup of the user record.
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
I've run the existing tests -- none of the ones that look relevant to the change broke.
As well, I did the following sequence
As org_admin1, create a new partner with the email [email protected]. Invite them. Accept the invitation (otherwise you are locked out). Logged in as org_admin2, check that you can switch to the new partner.
I also went through the request/distribution cycle once as that partner. No obvious flaws, but this was definitely a light pass.
NB
I have not, as yet, manually tested adding an existing user to an existing partner, or adding an existing user as a partner.
