human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard
verified publisher icon rubyforgood

feat: Allow to cancel request when partner is deactivated

Open zanetagebka opened this issue 6 months ago • 3 comments

Resolves #5231

Description

  • modify RequestDestroyService to not return false on validation for deactivated partners
  • add condition to not send email when partner is deactivated

List any dependencies that are required for this change. (gems, js libraries, etc.)

Include anything else we should know about. -->

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added test for service to chek that in case of deactivated partner action is running WITHOUT sending an email.

Instruction for manual testing are already in the ticket description.

Screenshots

zanetagebka avatar Jun 10 '25 18:06 zanetagebka

I am keeping it in draft for now because I would like to receive answers for few questions asked under the ticket. :)

When it will be clear I will adjust rest and make it ready.

zanetagebka avatar Jun 10 '25 18:06 zanetagebka

@zanetagebka The test that is failing appears to be related to your change.

cielf avatar Jun 18 '25 00:06 cielf

The manual functional test passes, though.

cielf avatar Jun 18 '25 17:06 cielf