ability to cancel requests from deactivated partners

[cielf]

Summary

Allow cancellation of requests from deactivated partners

Why

Letting the banks keep their pending requests as clear as possible. Makes dashboard more useful, too. There is no way for the banks to clean up old requests from deactivated partners. This causes the need to write migrations to do it for them.

Details

To see this, sign in as [email protected] click Requests. Note the name of one of the partners ("Request was sent by"). Click Partner Agencies, then All Partners, then click on that partner's name Click Deactivate Partner (under Partner Status). Click "Ok" in the confirmation pop-up. click Requests, then click "Cancel" for that partner's request Fill in a cancellation reason and click Ok

It currently comes up with an error. It should, instead, allow cancellation of the request.

PLEASE NOTE!!!!!

However, it should also not send the request cancellation email when we cancel a request from a deactivated partner.

Criteria for completion

• [ ] behaviour as described above
• [ ] automated tests to confirm the behaviour.

[zanetagebka]

@cielf I can take that one :)

[cielf]

It's yours!

[zanetagebka]

@cielf I have a question. Since there is a text informing user about sending email when cancelation is made: "This will be included in the email notification we send to the partner"

and since we will NOT be sending email in the case when parnter is deactivated do we want to:

1. hide the text completly
2. Display different text to inform user that in this case we will not send an email because partner is deactivated?

Also does it make sense to display some kind of info on the Requests page that will inform that this specific partner is deactivated? Som kind of label nearby the partner name for example that will let user know that this partner is no longer active?

[cielf]

Hey @zanetagebka -- Good questions.

For the cancelation page: Let's just add the text "Note: cancelation emails will not be sent to deactivated partners" after the text ""This will be included in the email notification we send to the partner"

For the requests page: Hmmm. It's a trade-off, but I think that the need to deal with unfulfilled requests from deactivated partners is uncommon enough that we don't need to make a special effort to draw attention to it.

[zanetagebka]

@cielf Will it be fine?

I also corrected typo on "cancelation" and give button a bit space between text

[cielf]

That looks good to me.

[github-actions[bot]]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

[cielf]

In review.

[github-actions[bot]]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

[github-actions[bot]]

Automatically unassigned after 7 days of inactivity.