human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Partner Visibility of items and child requests

Open cielf opened this issue 6 months ago • 11 comments

Summary

If the bank takes an action that will remove items from the partner's view, and there are child requests using those items, warn the bank (but do not prevent the action)

Why

Reminding banks of this prompts them to reach out to their partners (put up an announcement) --> less surprise.

Details

If the bank is taking any of these actions, check if items being removed from the partners' use are used in their child requests. If they are, give a confirmation dialog "Note: Items ([list of items]) are currently used by the partners in child requests. Proceed?"

  • item not visible
  • partner groups changing the items that are allowed
  • deactivation

Criteria for completion

  • [ ] changes as described above
  • [ ] automated tests supporting the changes

cielf avatar Jun 01 '25 15:06 cielf

I'd like to help with this!

jp524 avatar Jun 17 '25 19:06 jp524

Please do!

cielf avatar Jun 17 '25 20:06 cielf

I won't be able to work on this in a timely manner so it's probably best I leave this issue for someone else. @cielf would you be able to un-assign me?

I do have a couple of commits in this branch that tackle the "make item not visible" scenario, if that ends up being a helpful way to get started for the next person.

jp524 avatar Jul 03 '25 18:07 jp524

Will do. If it hasn't been picked up when you have time again, please feel free to tell us to assign it to you again!

cielf avatar Jul 03 '25 19:07 cielf

Can i work on this? I want to clarify one thing by child request means pending requests (items ordered by partners which arent fullfilled yet)

jeet12323 avatar Aug 15 '25 12:08 jeet12323

I think we may have this badly worded. We mean the items that are linked to the active children (If you go in as a partner and click "child request" you should see what we mean." So, the "Item needed" in the below screenshot.

The reason for the warning is so that the banks can reach out appropriately to the partners.

Image

cielf avatar Aug 15 '25 16:08 cielf

@cielf I just want to ask this task is only when item is deactivated by org right and it should give alert like this or should it be partners name mentioned can u check screenshot below

Image

jeet12323 avatar Aug 28 '25 08:08 jeet12323

It's when the item is deactivated by the organization. The idea is that they can then reach out to the partners affected.

I would tweak the message to read: "The following partners have active children with this item: " (and then the list of partners. Ideally in lower-case alphabetical order, to match up with other lists)

The partners should be listed in the error, but not the children. Because the bank doesn't need to know the children, we have always limited that information to the partners only for privacy reasons.

cielf avatar Aug 29 '25 01:08 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Sep 29 '25 00:09 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Oct 07 '25 00:10 github-actions[bot]

Already pr is created for this issue

jeet12323 avatar Oct 16 '25 17:10 jeet12323