What should happen to child requests if an item is made not-visible-to-partners/inactive

[cielf]

Summary

If an item is made not-visible-to-partners, and a partner tries to do a 'child request' that has that item in it, don't allow the request, but do tell the partner why.

Why

Smoother bank/partner communications

Details

This is in a relatively obscure part of the system -- probably best for people who are pretty familiar with it:

The rough steps to reproduce this are:

• set up children to need a particular item
• make that item not-visible-to-partners
• create a child request

Currently, it lets you -- but that request is likely to be turned down (there being a reason the item is not visible to partners -- probably that the bank no longer has a supply of it)

If this situation occurs, we should

• display an error message saying something like [Item name], requested for [child name] is not currently available for request.
• and not submit the request.

Critera for completion

• [ ] behaviour as described above
• [ ] automated tests to confirm the behaviour

---

Historical details

Origin

Notes from PR #4495

As for the likelihood of items being removed -- children age out of the smaller sizes of diapers and into bigger ones, so I would expect that the same child would have evolving needs over time. And a bank might take items off the list that they offer, if they don't have a steady supply of them. So there's definitely some edge cases there...

But/and that's an existing edge case, right? So technically out of scope for this PR (ed. 4495) . I'll put a note in our copious todo list to figure out what should happen (should, for example, the partner get a notification if the bank removes something one of their children needs?)

For Discussion with stakeholders

• should we inform the banks, and have them take it up with the partners, or inform the partners at the time they submit the request?

From discussion with stakeholders

No one attending the April 2025 stakeholder meeting uses child requests. Let's just inform the partners at the time they submit the request.

[Budmin]

I'd like to take a look at this.

[cielf]

Please do

[github-actions[bot]]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

[github-actions[bot]]

Automatically unassigned after 7 days of inactivity.