rubyforgood
5152 update requests export with inactive items
Checklist:
X I have performed a self-review of my own code, X I have commented my code, particularly in hard-to-understand areas, X I have made corresponding changes to the documentation, X I have added tests that prove my fix is effective or that my feature works, X New and existing unit tests pass locally with my changes ("bundle exec rake"), X Title include "WIP" if work is in progress. X I acknowledge that I will not force push my branch once reviews have started.
Resolves #5152 partially
Description
Updates the "requests" export to include inactive items in the columns.
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Ensure you have inactive items in your data set
- Navigate to the "Requests" page
- Click export before fix -> notice the number of columns
- Click export after fix -> notice the updated number of columns, including the inactive item(s)
Screenshots
requests_before_fix.csv requests_after_fix.csv
@dorner @cielf haven't forgotten this, I just started a new job a few weeks ago and haven't had much free to circle back and fix all this business
Looks like this has some feedback; I think if anyone else would like to take a look at completing it then that would be welcome!
