rubyforgood
Bug-5152-update-donations-export-to-include-inactive-unused-items
Checklist:
X I have performed a self-review of my own code, X I have commented my code, particularly in hard-to-understand areas, X I have made corresponding changes to the documentation, X I have added tests that prove my fix is effective or that my feature works, X New and existing unit tests pass locally with my changes ("bundle exec rake"), X Title include "WIP" if work is in progress. X I acknowledge that I will not force push my branch once reviews have started.
Parital #5152 - partially, will be broken up into multiple PRs
Description
This modifies the query used by the Donations export to also include inactive items and items that were not donated, so that the headers are consistent with the "Distributions" export logic.
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Ensured test data included inactive and non-donated items. Giving the item a unique name is super important.
- Exported out Distribution export as reference point
- Exported the Donations export before the changes
- Exported the Donations export after the changes, compared against Distributions for item columns to ensure match.
- Updated and shored up test coverage accordingly
PLease see attached XLXS files to help make sense of this.
This CSV will serve as a reference point for Donations for the item columns, at least. Distributions_as_reference.csv
This is an example of the data BEFORE the fix -- note how many fewer item columns are in the export donations_before.csv
This is the fixed version. Note that the total number of item columns matches the Distribution export donations_after_fix.csv
For this, it looks like we should switch to a CSV fixture based spec, and then it should be ready to merge.
