rubyforgood
4987 annual report across years, implementation and unit tests
Resolves #4987
Description
- Give user the ability to download annual surveys from the first reportable year to the latest completed year.
- I was thinking whether I should add or change the existing ExportReportCSVService class to handle this usecase but decided to keep it simple as my first contribution.
Type of change
- New feature (non-breaking change which adds functionality)
- This change requires a documentation update
- Documentation update
How Has This Been Tested?
- I created unit test to see if csv result is correct.
- Testing manually by clicking button.
Screenshots
maintainers, please let me know if I need to change anything. I will update the user documentation later.
@alexwitedja:
Go ahead and update the user documentation as part of this PR, please. We wouldn't want to merge without it.
Initial functional checks look good. I'm going to want to test this against production data, but also passing it on to @dorner for technical checks.
@alexwitedja When I tested against production data, I'm seeing some anomalies. They may well be pre-existing, but I want to investigate further to find out what's going on.
(Edit: The anomalies are enough that we might as well hold off on @dorner checking this until I'm done. Go ahead with the user guide update, though, please -- they shouldn't affect that.)
I'm at the end of my time on this for today -- So far, I'm seeing that there is a a difference between what is coming out for Cloth diapers distributed for some of the earlier years between what happens on an export of the individual year, and what is in the export that goes over all the years.
I suspect there is something year-specific in the existing code.
(This does not surprise us at all -- it's probably why we ranked this as "intermediate" rather than beginner. )
I've added a "Help Wanted" tag to the parent issue, as it looks like this is fallow.