human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Reconcile itemrequests and requestitems

Open cielf opened this issue 9 months ago • 13 comments

Summary

ItemRequests and RequestItems seem to have largely the same information We should just use one of them

Why?

This is cleanup -- I'm pretty sure it's a legacy of when we had two apps

Details

It looks like the way to go with this will be to rework the distribution printout to use ItemRequest instead of RequestItem -- then we should be able to get rid of RequestItem

Job for the core team

-- confirm that ItemRequest and RequestItem are in agreement in the prod data. If not - how long ago is the discrepency?

Context from the RubyForGood 2024 event

Migration on branch from event to attempt to synchronize these in prod data: https://github.com/rubyforgood/human-essentials/blob/kp/merge-line-items-at-request-save__data-migration/db/migrate/20240601155348_dedup_item_requests_in_requests.rb

(the event was 24 weekend if you want to see the conversation (that's the weekend before memorial day weekend for the US folk…e.g., see comments in human-essentials channel leading up to this one: https://rubyforgood.slack.com/archives/C6WLZL0DD/p1717184706390639)

Criteria for completion

  • [ ] confirm that the info is in agreement between item requests and requestitems
  • [ ] rework code using RequestItem to use ItemRequest. Thorough testing.
  • [ ] migration to remove RequestItem

cielf avatar Mar 09 '25 14:03 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Apr 09 '25 00:04 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Apr 16 '25 00:04 github-actions[bot]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar May 17 '25 00:05 github-actions[bot]

This is #5196, yes? (Is it only partial? )

cielf avatar May 17 '25 03:05 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jun 18 '25 00:06 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Jun 25 '25 00:06 github-actions[bot]

I know @awwaiid is working on this -- reassigning.

cielf avatar Jun 25 '25 16:06 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jul 26 '25 00:07 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Aug 02 '25 00:08 github-actions[bot]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Sep 03 '25 00:09 github-actions[bot]

Note: Took a quick look at 5196 -- confirmed that it doesn't do the migration, so there will be more to do on this one once that is merged.

cielf avatar Sep 03 '25 12:09 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Oct 05 '25 00:10 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Oct 13 '25 00:10 github-actions[bot]