human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

feat: add ability to add and show partner-specific information

Open khiga8 opened this issue 10 months ago • 4 comments

Partial: #5020

Description

  • [x] Database migration to add new info_for_partner field to the partner.rb model.
  • [x] Update the create/edit partner information frontend with a new textarea. (for partner)
  • [x] Update the partners_controller.rb to accept new field params.
  • [x] Update the dashboard page for partner to add information.
  • [x] Added a test

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I updated the spec/system/partner_system_spec.rb spec.

Screenshots

New form field with the label 'Partner specific information (500 characters) Partner specific information is shown on the partner dashboard under the heading 'Info'

khiga8 avatar Mar 06 '25 20:03 khiga8

Note: Apparently this PR does not include the user guide fixes. Therefore downgrading the "Fixes" to "Partial"

cielf avatar Apr 09 '25 19:04 cielf

Heads up to @khiga8 It may take me a few days to get this tested.

cielf avatar Apr 09 '25 19:04 cielf

Hey @khiga8 -- thanks for this! It does what was asked for -- excluding the user guide changes -- I'm seeing that I should have also asked for it to be added in to the bank's view of the partner, between notes and partner profile. Are you up for handling that, or shall I put it into a new issue?

ps. this still has to go through a technical review, and heads up -- we won't be merging this without the user guide changes.

cielf avatar Apr 11 '25 18:04 cielf

@dorner -- when you've reviewed this, please toss it back to me, and I'll handle the user guide, since @khiga8 doesn't think they have enough context.

cielf avatar Apr 14 '25 14:04 cielf

Thanks @khiga8 ! I needed to make some small changes, so I did that over at https://github.com/rubyforgood/human-essentials/pull/5270 . I'm closing this, but your work will soon be merged!

awwaiid avatar Jul 06 '25 16:07 awwaiid