rubyforgood
In new purchase, Category purchase values must be non-negative
Summary
The category purchase values in new purchase / edit purchase should be constrained to be non-negative
Why?
Hygiene
Details
To see this, sign in as [email protected], then click "Purchases" and "New Purchase" in the left-hand menu.
Enter enough information to be able to save, including at least one negative number in the "purchase total for..." (still have the purchase total add up to the 4 category totals. Save.
It allows it! And shouldn't.
Put in checks so that none of the 'Purchase Total for..." fields can be negative.
Criteria for completion
- [ ] behaviour as described above
- [ ] tests to confirm behaviour as described above.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cielf Hi! I noticed this issue hasn’t had recent activity. I’m interested in working on this for a class project. If the original contributor is no longer working on it, I’d be happy to take it over.
@boydstoni -- The changes that are left are essentially just changing the name of a test and removing a comment. If you want something that's still simple, but where you would make a visible difference, may I suggest #5063 -- it's just changing the styling on some buttons. (if you do -- comment on it and I will assign you).
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
@harsh1205 Will do! If you look at the PR that was submitted - you can see that it really only needs a couple of very small changes to make it pass. (We just haven't gotten around to it)