rubyforgood
Total on Hand is Unknown for inactive Items on Itemized Reports -- should be 0.
Summary
In itemized reports, the total on hand for inactive items should be 0, rather than "Unknown"
Why
We only allow items to be deactivated if the total on hand is 0, so we do know.
Details
To see this, sign in as [email protected],
Reduce the quantities in inventory on Adult Briefs (Medium/Large) to 0 (I usually use a couple of distributions to do this.), then go in to Inventory | Items & Inventory and deactivate the item
click reports, then 'Itemized Donations'.
You'll see that the Total On Hand for Adult Briefs (Medium/Large) is Unknown. We know that it is 0. (screenshot is from a different example, but you get the idea)
This is left from when we allowed deactivation of items without first 0ing the inventory.
The Total On Hand should be 0 for any inactive item.
Confirm and fix this behaviour on Donations - Itemized, Distributions - Itemized, and Purchases - Itemized.
Criteria for Completion
- [ ] Total On Hand shows 0 for any inactive item
- [ ] Tests to confirm
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
@cielf I couldn't find the "Purchases - Itemized" page, it was removed in some change or renamed?
@GiovannyCordeiro My error -- Apparently we don't have one for the purchases, which is against our usual pattern.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
If someone else wants to take this on (as @GiovannyCordeiro has had to go quiet for awhile), please follow on with PR #5235.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
Hi @DasTapan, I’ve already created a PR for this issue, and it’s currently under review. 5004 Show 0 instead of “Unknown” for inactive items in itemized reports #5400