human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard
verified publisher icon rubyforgood

4672 header alignment

Open inane-pixel opened this issue 1 year ago • 5 comments

Resolves #4672

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue) item_row.distribution_quantity aligned right and FMV aligned right

How Has This Been Tested?

Screenshots

inane-pixel avatar Oct 11 '24 14:10 inane-pixel

If anyone else is reviewing this, please refer to PR 4715 and issue 4672

cielf avatar Oct 11 '24 17:10 cielf

@inane-pixel Still showing extra changes.

cielf avatar Oct 14 '24 13:10 cielf

@cielf What are the extra changes? I did delete db/migrate/20180704003450_create_flipper_tables.rb, but I was recommended to do that in the Slack channel because I was receiving error messages with createFlipperTables image

inane-pixel avatar Oct 18 '24 15:10 inane-pixel

Asking for a review from @awwaiid

cielf avatar Oct 20 '24 03:10 cielf

It looks to me like you've made unrelated changes to database.yml, and that you deleted a migration from 2018 -- @awwaiid mentioned a migration from 2024.

cielf avatar Oct 20 '24 03:10 cielf

@cielf I see the errors now. I tried making and committing a new branch, hopefully without the extra changes. 4730

inane-pixel avatar Oct 22 '24 22:10 inane-pixel

Closing this PR because there is a replacement

cielf avatar Oct 23 '24 15:10 cielf