rubyforgood
Import partners should note when there were partners that couldn't be imported. (if, for example., the email was not formatted correctly).
Summary
If a partner import can't import all the partners, it should tell the user, rather than just saying "Partners imported successfully!"
Why
Current situation is potentially misleading
Details
If a bank has improperly formatted emails in its partner import file, the process currently skips over them silently. It should provide a list of the partners that did not import correctly, so that they can be added by hand.
Suggested Message format: "The following partners did not import correctly. This may be due to an improperly formatted email: [list of partner names]
Recreation
sign in as [email protected] Grab an example partner import file [PartnerAgencies | All Partners | Import Partners | Download example file]. Change the middle partner to have an invalid email format (I just used "no email"). Then upload it (from the same popup). It will say the partners uploaded successfully, but if you look at the partner list, the one you changed to have "no email" did not (as it should not!).
Criteria for completion
- [ ] better error messaging on invalid partner email formats on import partner, as described above
- [ ] tests to demonstrate
