human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

add logins for brand new bank to contributing.md

Open cielf opened this issue 1 year ago • 5 comments

Summary

Add the ids for sf_org to the contributing.md

Why?

Developers don't know what that bank is and what it is used for. We should explain it.

Details

Add another group of users to the Credential section of Contributing.md

Bank Users (brand new bank) Organization Admin Email: [email protected] Password: password!

User Email: [email protected] Password: password!

Criteria for completion

  • [ ] information added to contributing.md

cielf avatar Sep 30 '24 02:09 cielf

i'm trying to understand this issue, from what is written so far, there's a need to add new credentials to the documentation (contribution.md), this is for a user type that is "Brand new bank". What this implies is that the credentials should be available in seeders file as well, which actually is present in seeds.rb.

So this is merely updating documentation to add a variant of a Bank User, called brand new bank. did i get that right?

sbpipb avatar Oct 04 '24 07:10 sbpipb

I'm trying to understand what "Add the ids for sf_org to the contributing.md" mean, is it just the Organization id of the actual SF org?

from the code base

  organization.name    = "SF Diaper Bank"
  organization.street  = "P.O. Box 12345"
  organization.city    = "San Francisco"
  organization.state   = "CA"
  organization.zipcode = "90210"
  organization.email   = "[email protected]"
end
Organization.seed_items(sf_org)

i'm missing the need for this, mainly cause i'm new to this project. i'm happy to work on this as well missing a few pieces to the big picture of things.

sbpipb avatar Oct 04 '24 07:10 sbpipb

In the contributing.md, there is a a section for Bank Users, where the ids and passwords for the various roles live.

We would like to have the ids and passwords as specified in the issue added to that section. Essentially just as they have been specified in the issue. I would put the section between the current Bank Users section and the current Partner Users section. (I'm seeing it as somewhere around line 66).

cielf avatar Oct 04 '24 15:10 cielf

Sorry to jump in, but I just wanted to mention that this is the documentation section that this issue refers to: link. Hope it helps! :)

lsfernandes92 avatar Oct 08 '24 19:10 lsfernandes92

What's the status of this one? I would like to pick this one if you don't intend to @sbpipb

lsfernandes92 avatar Oct 14 '24 14:10 lsfernandes92

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Nov 14 '24 00:11 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Nov 21 '24 00:11 github-actions[bot]

@lsfernandes92 Are you still interested in this one?

cielf avatar Nov 21 '24 02:11 cielf

@cielf I'd love to pick this one up now, and I am assigning it to myself. I hope that's okay.

lsfernandes92 avatar Jan 21 '25 23:01 lsfernandes92

@lsfernandes92 Oh -- it looks like it's already been taken care of (probably when we added another bank so we had good test data for manually checking things that should only be seen by the current organization), and didn't get closed. Sorry about that! Closing it now.

cielf avatar Jan 22 '25 00:01 cielf