Add missing kit rspecs, DRY up kit base items and report service

[jimmyli97]

Split off from PR #4585 Various refactors and documentation changes

Description

• Rename item.kits scope to item.housing_a_kit
• DRYs up kit base_item seeding
• Removes duplicated code and rspec from ChildrenReportService
• Add rspecs to:
  • prevent kit base_item deletion
  • test item.is_in_kit?, item.loose, item.housing_a_kit
• Add documentation

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Documentation update

How Has This Been Tested?

passes test suite

[cielf]

@jimmyli97 FYI: We had an urgent fix that required all the senior contributors this week , so we didn't get to look at this again. Hopefully this week will go better.

[dorner]

@jimmyli97 are you able to finish this off?

[cielf]

Hey @jimmyli97 -- Just checking if you are still working on this. If we don't hear from you in a couple weeks, we'll assume not. Thank you for all your work on this in either case!

[jimmyli97]

If someone wants to finish this that's fine, otherwise I can hopefully get to this next week

[dorner]

All good on my side. @cielf did you want to kick the tires?

[cielf]

Yes. Should be able to fit it in today or tomorrow.

[cielf]

Looks good after a light kicking.

[github-actions[bot]]

@jimmyli97: Your PR Add missing kit rspecs, DRY up kit base items and report service is part of today's Human Essentials production release: 2024.12.15. Thank you very much for your contribution!