human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

[PACKS] item units for new requests should not be set initally.

Open cielf opened this issue 1 year ago • 4 comments

Summary

New request for packs was implemented with a default. We need it to have no default

Why

Reduction of partner error -- some partners will do one unit, some another, within the same bank.

Details

The custom units field for the request should not be defaulted -- it should start with a 'please select...' (althernatively we could do it as a non-selected radio button group). It must, however, be selected on save if the quantity for the corresponding item is not 0.

Criteria for completion

  • [ ] behaviour as described above
  • [ ] automated tests to demonstrated the behaviour.

cielf avatar Aug 25 '24 14:08 cielf

Hey @cielf, I'd like to work on this issue. Just to clarify, this is on the new distribution form right?

isaiah3031 avatar Aug 30 '24 01:08 isaiah3031

Hey @isaiah3031 -- Thank you for your interest! We're really close to getting the whole PACKS milestone done, and this is on the critical path, so I've asked @awwaiid (one of our senior staff) to take it on just for speed's sake. May I suggest #4343 as an alternative?

cielf avatar Aug 30 '24 13:08 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Sep 30 '24 00:09 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Oct 07 '24 00:10 github-actions[bot]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Nov 07 '24 00:11 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Nov 14 '24 00:11 github-actions[bot]

This was done in #4510 !

2024-12-08_16-44

awwaiid avatar Dec 08 '24 21:12 awwaiid