human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

[WIP] Add feature to print unfulfilled requests as a picklists PDF

Open norrismei opened this issue 1 year ago • 2 comments

Resolves #4406

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

Screenshots

Screen Shot 2024-08-18 at 8 13 34 AM

norrismei avatar Aug 16 '24 06:08 norrismei

Ready for a review @norrismei?

awwaiid avatar Aug 25 '24 04:08 awwaiid

@awwaiid There are a few changes I need to make and then I'll fill out the PR description and mark this ready for review.

norrismei avatar Aug 29 '24 18:08 norrismei

@norrismei Please do change the button to have the number of unfulfilled requests..

e.g. Print Unfulfilled Picklists (44)

cielf avatar Sep 01 '24 15:09 cielf

@cielf I added the number of unfulfilled requests to the print button, and yes, unfulfilled requests includes "started" requests.

@dorner I scoped the query to the organization (thanks for catching) and updated statuses to be more obvious. Awaiting clarity on item_requests vs request_items.

norrismei avatar Sep 03 '24 23:09 norrismei

Hey @norrismei - just noting that the lint is failing -- just a wee thing to change there.

cielf avatar Sep 12 '24 18:09 cielf

@norrismei, but do please change to @item_requests -- we are going to be stripping out request_items entirely in the near future.

I think I'll hold off on a final functional check until that's in.

cielf avatar Sep 12 '24 18:09 cielf

@dorner unit tests added. Both for the PDF and the button on the index page

norrismei avatar Sep 24 '24 07:09 norrismei

@norrismei FYI: We had an urgent fix that required all the senior contributors this week , so we didn't get to look at this again. Hopefully this week will go better.

cielf avatar Sep 28 '24 17:09 cielf

@norrismei: Your PR Add feature to print unfulfilled requests as a picklists PDF is part of today's Human Essentials production release: 2024.10.20. Thank you very much for your contribution!

github-actions[bot] avatar Oct 20 '24 16:10 github-actions[bot]