human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Published 20 hours ago • verified publisher icon rubyforgood

#4217 kit factory refactor

Open jimmyli97 opened this issue 6 months ago • 3 comments

Addresses #4217 for kits

Description

  • #4217 Hard codes all uses of kit factory
  • Remove kit :with_item trait and replace with KitCreateService - this is to make it easier for me to rewrite kit creation later when working on #3707

Kit :with_item trait removal conflicts with #4582, recommend merging that one first then I can merge and change their rspecs in this PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How Has This Been Tested?

passes all rspecs

jimmyli97 avatar Aug 08 '24 23:08 jimmyli97