#4217 kit factory refactor

[jimmyli97]

Addresses #4217 for kits

Description

• #4217 Hard codes all uses of kit factory
• Remove kit :with_item trait and replace with KitCreateService - this is to make it easier for me to rewrite kit creation later when working on #3707

Kit :with_item trait removal conflicts with #4582, recommend merging that one first then I can merge and change their rspecs in this PR

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Documentation update

How Has This Been Tested?

passes all rspecs

[jimmyli97]

the failing tests are flaky ones, added them to the list

[jimmyli97]

I split off the cleanup pieces into PR #4665

[cielf]

@jimmyli97 FYI: We had an urgent fix that required all the senior contributors this week , so we didn't get to look at this again. Hopefully this week will go better.

[dorner]

@jimmyli97 this looks good, but there's a conflict now. :(

[jimmyli97]

can't recreate failing test locally, think this is a flake, added to list

[jimmyli97]

failing test is a flake added to list

[cielf]

@dorner - does this need a final look-see before merging? (there have been changes since you approved)?

[github-actions[bot]]

@jimmyli97: Your PR #4217 kit factory refactor is part of today's Human Essentials production release: 2025.01.19. Thank you very much for your contribution!