4283 period supplies

[jadekstewart3]

Checklist:

• I have performed a self-review of my own code,
• I have commented my code, particularly in hard-to-understand areas,
• I have made corresponding changes to the documentation,
• I have added tests that prove my fix is effective or that my feature works,
• New and existing unit tests pass locally with my changes ("bundle exec rake"),

-->

Resolves #4283

Description

Modify the Period supply report to include items from kits that are both donated and purchased.

Include anything else we should know about. -->

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added unit tests within the test suit to individually test newly added methods.

[cielf]

@jadekstewart3 Yay! I think the failed test is unrelated, but please address the things Rubocop is unhappy with.

Don't expect my functional review until later in the week.

[jadekstewart3]

@cielf @dorner There is a CI failure, but I checked out the file and it doesnt seem to be one that I touched

[jadekstewart3]

@cielf I added another distribution to see if my expected would increase by 200, and it seems to be working. Would you mind taking a peek at my test set up to ensure I am creating the distribution properly? The new distribution is pad_and_tampon_kit_distribution, kit is names similarly. Thank you! Im not sure what is goin on so any insight would be much appreciated!

[cielf]

Yeah - I double-checked it. definitely just showing the pads. Have you tried the combination of loose and kitted period supplies.

@cielf I added another distribution to see if my expected would increase by 200, and it seems to be working. Would you mind taking a peek at my test set up to ensure I am creating the distribution properly? The new distribution is pad_and_tampon_kit_distribution, kit is names similarly. Thank you! Im not sure what is goin on so any insight would be much appreciated!

Before I dig in too much -- I noticed that you are misspelling "Menstrual" as "Menstral". That might be the whole problem?

[jadekstewart3]

@cielf well that is embarrassing!

[jadekstewart3]

@cielf I think I have an idea of what youre asking, but Im not exactly sure. Are yall still holding office hours on sundays? Maybe I can chat with someone to help me get a better idea?

[cielf]

Yes, we are . I'm probably the best person to talk it though with, and I intend to be there.

[cielf]

Just a note for anyone else who is reviewing -- from a conversation with the stakeholder circles, it was agreed that we can't really reasonably calculate the period supplies per adult per month (and it's not as meaningful a number as diapers per month, anyway, because different period supplies are used at different rates). So we're removing that from the annual survey.

[cielf]

With that in mind, I will take another pass at this from a functional pov (probably Friday) but I think we're at the point where we should have @dorner take a look.

[dorner]

Technical review looks fine.

[cielf]

@jadekstewart3 Thank you very much for your hard work and patience on this!

[github-actions[bot]]

@jadekstewart3: Your PR 4283 period supplies is part of today's Human Essentials production release: 2024.10.27. Thank you very much for your contribution!