human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Resolves #4544. filter manufacturer donations summary report by date

Open guswhitten opened this issue 1 year ago • 1 comments

Checklist:

  • I have performed a self-review of my own code,
  • I have commented my code, particularly in hard-to-understand areas,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works,
  • New and existing unit tests pass locally with my changes ("bundle exec rake"),
  • Title include "WIP" if work is in progress.

Resolves #4544

Description

Manufacturer Donations Summary Report individual manufacturers donations count were not being filtered by the selected date range (past year).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tests added in spec/requests/reports/manufacturer_donations_summary_spec.rb

Screenshots

Before: human-essentials-4544-before

After: human-essentials-4544-after

guswhitten avatar Jul 30 '24 11:07 guswhitten

@ dorner - bit late in the day, but if you have the cycles still, could you take a technical look at this? (I'll do the last functional confirm either later today or in the morning)

cielf avatar Aug 02 '24 20:08 cielf

@dorner Bringing this one back to your attention.

cielf avatar Sep 06 '24 14:09 cielf

Functionality looks good.

cielf avatar Sep 06 '24 14:09 cielf

@guswhitten: Your PR Resolves #4544. filter manufacturer donations summary report by date is part of today's Human Essentials production release: 2024.09.08. Thank you very much for your contribution!

github-actions[bot] avatar Sep 08 '24 14:09 github-actions[bot]