human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

[BUG] Mismatch between overall manufacturer numbers and individual manufacturer donation numbers

Open cielf opened this issue 1 year ago • 3 comments

Summary

The manufacturer donations report individual values are not being constrained by the timeframe selected. They should be.

Details

This report is found under "Reports | Donations-Manufacturer" in the left hand menu.

The manufacturer donations report is showing the total manufacture donations according to the selected timeframe, but the top manufacturers are not showing according to the selected timeframe.

Example, from January 9, 2024 Image

Some things to consider: 1/ Are the top manufacturers being selected and ranked according to the timeframe? 2/ The values shown for each of those manufacturers should be constrained by the timeframe.

Criteria for completion

  • [ ] The top manufacturers are selected and ranked according to the activity during the timeframe
  • [ ] The values shown for each manufacturer in that list are the donations during the selected timeframe
  • [ ] Tests to demonstrate the above.

cielf avatar Jul 21 '24 15:07 cielf

@cielf I can take on this issue

guswhitten avatar Jul 29 '24 11:07 guswhitten

You've got it!

cielf avatar Jul 29 '24 17:07 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Aug 29 '24 00:08 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Sep 05 '24 00:09 github-actions[bot]