human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Add more date range selection options #4518

Open pshong79 opened this issue 1 year ago • 1 comments

Resolves #4518

Description

This change is to add more date range selections through the application - specifically "Prior Year" and "Last 12 Months".

"Prior Year" is from January 1 through December 31 of the previous year. "Last 12 Months" is from the day after today of the previous year through today. For example, if today is July 14, 2024, the range should be July 15, 2023 to July 14, 2024.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested manually Add a couple of specs in distribution_by_county_system_spec for "Prior Year" and "Last 12 Months" date range selections.

Screenshots

Before: Screenshot 2024-07-14 at 22 20 32

After: (Last 12 Months) Note: Today's date is July 14, 2024. Screenshot 2024-07-14 at 22 19 58

(Prior Year) Screenshot 2024-07-14 at 22 19 46

pshong79 avatar Jul 15 '24 03:07 pshong79

Sorry, it looks like work may continue to take up most of my time for the next few weeks. If someone wants to pick this up and take it across the finish line, that is totally fine. Otherwise, I can come back to it once work settles back down again.

The only remaining task left to do is fix these two tests:

  • https://github.com/rubyforgood/human-essentials/pull/4533/files#diff-8411af524d3b6416c2f8de3fa83b1e3210a7700414c9a4041878d3f6b97e0225R38
  • https://github.com/rubyforgood/human-essentials/pull/4533/files#diff-8411af524d3b6416c2f8de3fa83b1e3210a7700414c9a4041878d3f6b97e0225R38

pshong79 avatar Aug 05 '24 14:08 pshong79

@pshong79 I can help wrap this up.

Fixed those two leftover tests so it should be ready for review again!

coalest avatar Nov 29 '24 12:11 coalest

@pshong79: Your PR Add more date range selection options #4518 is part of today's Human Essentials production release: 2024.12.01. Thank you very much for your contribution!

github-actions[bot] avatar Dec 01 '24 15:12 github-actions[bot]

@pshong79 I can help wrap this up.

Fixed those two leftover tests so it should be ready for review again!

Thanks @coalest! Sorry for the late reply. Thank you for wrapping this up for me!

pshong79 avatar Feb 02 '25 02:02 pshong79