human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Add In Kind value to Donation export

Open cielf opened this issue 1 year ago • 3 comments

Summary

Add Donation-level in-kind value to Donation export

Why?

Helps the banks with external paperwork

Details

Add the in-kind value, at a donation level, to the Donation export. Put it before the item breakdown

Note

  1. We checked with the user who requested this -- they said that item-level would be lovely, but not necessary. Unless someone specifically needs it, let's leave it out for reasons of file size and manageablilty of working with the exported file.
  2. We will need to highlight this in the announcements when it goes in, as it will need people to adjust their external use of the export.

Criteria for completion

  • [ ] In-kind value included in donation export, before the items
  • [ ] tests to demonstrate

cielf avatar Jul 14 '24 15:07 cielf

can you just tell me where in the code file responsible for generating the Donation export, so that i can navigate to it directly and add donation level in it after understanding the code

Sahil-Dash avatar Jul 15 '24 11:07 Sahil-Dash

To navigate to the donation export, sign in as [email protected], click "Donations', the "All Donations", then "Export Donations".
You'll likely want to look at app/services/exports/export_donations_csv_service.rb

cielf avatar Jul 15 '24 14:07 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Aug 28 '24 00:08 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Sep 04 '24 00:09 github-actions[bot]

Hi! Taking a look at this. The in kind value for a donation is donation.value_per_itemizable right?

jparcill avatar Sep 14 '24 19:09 jparcill

That doesn't sound quite right -- I'll take a look. It might just be badly named. (Edit. Oh. I see why it's named that. ) Yes. That's right.

cielf avatar Sep 15 '24 19:09 cielf

Cool have a PR up!

jparcill avatar Sep 16 '24 03:09 jparcill